-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update work item template #2818
base: master
Are you sure you want to change the base?
Conversation
- other (describe below) | ||
label: Current State | ||
description: Describe the current state and state the problem | ||
placeholder: Currently, the `print_a` cheatcode prints `"a"` to stdout. This is problematic because user might want it to be printed on their actual printer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
placeholder: Currently, the `print_a` cheatcode prints `"a"` to stdout. This is problematic because user might want it to be printed on their actual printer. | |
placeholder: e.g. Currently, the `print_a` cheatcode prints `"a"` to stdout. This is problematic because user might want it to be printed on their actual printer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Placeholder will be displayed as a semi-opaque text in the text box that will disappear once user starts typing. I don't thing e.g.
is necessary in that case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine, so let's remove it from all placeholders for consistency
.github/ISSUE_TEMPLATE/work_item.yml
Outdated
description: Describe the issue here. | ||
label: Correct State | ||
description: Briefly describe the correct state | ||
placeholder: `print_a` should magically detect if user wants to print to stdout or a printer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
placeholder: `print_a` should magically detect if user wants to print to stdout or a printer. | |
placeholder: e.g. `print_a` should magically detect if user wants to print to stdout or a printer. |
.github/ISSUE_TEMPLATE/work_item.yml
Outdated
attributes: | ||
label: Additional Context | ||
description: Provide additional context on the desired state. | ||
placeholder: E.g. if we can detect any printers in local network it might indicate that user wants to print to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
placeholder: E.g. if we can detect any printers in local network it might indicate that user wants to print to it. | |
placeholder: e.g. If we can detect any printers in local network it might indicate that user wants to print to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got such error while opening in the file view:
https://github.com/foundry-rs/starknet-foundry/blob/0e794f2a35571692bd5e13904319a4b1f058cd81/.github/ISSUE_TEMPLATE/work_item.yml
Co-authored-by: ddoktorski <[email protected]>
@kkawula Resolved, thanks |
Closes #2810
Introduced changes
Checklist
CHANGELOG.md